Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for unserializing old serialization formats #10986

Merged

Conversation

greg0ire
Copy link
Member

No description provided.

@greg0ire greg0ire requested a review from derrabus October 10, 2023 10:54
@derrabus
Copy link
Member

Should we keep the test for the 2.15 format? It's still the current one, isn't it?

@derrabus derrabus added this to the 3.0.0 milestone Oct 10, 2023
@greg0ire greg0ire force-pushed the drop-support-for-unserializing-old-format branch from 8a71172 to 7250ade Compare October 10, 2023 12:22
mpdude
mpdude previously approved these changes Oct 10, 2023
morozov
morozov previously approved these changes Oct 10, 2023
SenseException
SenseException previously approved these changes Oct 10, 2023
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the test for the 2.15 format? It's still the current one, isn't it?

Should it be renamed?

@greg0ire greg0ire marked this pull request as draft October 11, 2023 05:30
@greg0ire greg0ire dismissed stale reviews from SenseException and morozov via 1665435 November 11, 2023 17:41
@greg0ire greg0ire force-pushed the drop-support-for-unserializing-old-format branch from 5ddaaaa to 1665435 Compare November 11, 2023 17:41
@greg0ire
Copy link
Member Author

Should it be renamed?

I don't think so, if it does not change.

@greg0ire greg0ire marked this pull request as ready for review November 11, 2023 17:42
@greg0ire greg0ire force-pushed the drop-support-for-unserializing-old-format branch from 1665435 to 010cd94 Compare November 11, 2023 17:44
@greg0ire
Copy link
Member Author

Note that this removes txt files that I should have removed in my last merge up.

@greg0ire greg0ire merged commit 21466a0 into doctrine:3.0.x Nov 14, 2023
64 checks passed
@greg0ire greg0ire deleted the drop-support-for-unserializing-old-format branch November 14, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants