Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the support for enum types in the ResultSetMappingBuilder #11018

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix the support for enum types in the ResultSetMappingBuilder #11018

merged 1 commit into from
Oct 18, 2023

Conversation

stof
Copy link
Member

@stof stof commented Oct 17, 2023

Fixes #11017

@greg0ire
Copy link
Member

greg0ire commented Oct 17, 2023 •
edited
Loading

The failures look unrelated, but I think they actually are somehow: PHPUnit is happy with origin/2.16.x right now.

@stof stof force-pushed the fix_result_set_builder_enum branch from 461415a to 866283d Compare October 18, 2023 08:04
@derrabus derrabus added the Bug label Oct 18, 2023
@stof
Copy link
Member Author

stof commented Oct 18, 2023

@greg0ire this is fixed now

@greg0ire greg0ire added this to the 2.16.3 milestone Oct 18, 2023
@greg0ire greg0ire merged commit 0b7fe18 into doctrine:2.16.x Oct 18, 2023
58 checks passed
@greg0ire
Copy link
Member

Thanks @stof !

@stof stof deleted the fix_result_set_builder_enum branch October 19, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.16.3
Development

Successfully merging this pull request may close these issues.

ResultSetMappingBuilder does not properly support enumType
3 participants
@stof @greg0ire @derrabus