DefaultRepositoryFactory: single repository for aliased entities #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->repositoryList[$class] = $repository; | ||
|
|
||
| if ($class !== $entityName) { | ||
| $this->repositoryList[$entityName] = &$this->repositoryList[$class]; |
There was a problem hiding this comment.
no need to assign it by reference. It is an object
There was a problem hiding this comment.
I've entered paranoid-mode :) fixed it!
|
@stof maybe you mean line 50? I've left the original |
|
Ok, @Ocramius . I've updated the commit. |
|
@giosh94mhz checking out locally and merging, thanks! |
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 18, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual implementation of
DefaultRepositoryFactorycreate multiple instances for a single entity if is accessed by multiple namespace aliases.I've patched
DefaultRepositoryFactory::getRepositoryso that aliases are resolved before saving the reference into therepositoryList.Just to not affect performance of existing implementation, I've added to therepositoryListboth the aliased class name and the fully-qualified class name, but only the latter is required.