Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant tags #11162

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Remove redundant tags #11162

merged 1 commit into from
Jan 16, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jan 16, 2024

The any tags inside the definition for mapped superclasses and embeddables duplicate what is already done for entities.

The other removed "any" tags are also redundant, as they duplicate what's already done inside the grandparent "choice" tag.

Starting with version libxml 2.12, such redundant tags cause errors about the content model not being "determinist".

Fixes #11117

The "any" tags inside the definition for mapped superclasses and
embeddables duplicate what is already done for entities.

The other removed "any" tags are also redundant, as they duplicate
what's already done inside the grandparent "choice" tag.

Starting with version libxml 2.12, such redundant tags cause errors
about the content model not being "determinist".

Fixes doctrine#11117
@greg0ire greg0ire merged commit 398ab05 into doctrine:2.17.x Jan 16, 2024
@greg0ire greg0ire deleted the fix-libxml-compat branch January 16, 2024 21:32
@greg0ire greg0ire added this to the 2.17.3 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOMDocument schemaValidate error migrating to PHP 8.2
2 participants