Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed new line in docblock #1126

Merged
merged 2 commits into from
Aug 30, 2014
Merged

Fixed new line in docblock #1126

merged 2 commits into from
Aug 30, 2014

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Aug 30, 2014

Fixes docblock generation for set, get, add and remove methods (change introduced in #1067 2478037):

Before:

/**
 * Set myProp.

 *
 * @param integer $myProp
 *
 * @return MyEntity
 */

After:

/**
 * Set myProp.
 *
 *
 * @param integer $myProp
 *
 * @return MyEntity
 */

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3288

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

it seems to me like there's just one * too much, no?

@phansys
Copy link
Contributor Author

phansys commented Aug 30, 2014

I agree @Ocramius, but I don't understand the reason of the original PR (there is already an asterisk after description block).
If you want, I can just remove the line break; but it is a full revert of #1067.

@Ocramius
Copy link
Member

Yup, no problem with that

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 30 August 2014 04:09, Javier Spagnoletti [email protected]
wrote:

I agree @Ocramius https://github.com/Ocramius, but I don't understand
the reason of the original PR (there is already an asterisk after
description block).
If you want, I can just remove the line break; but it is a full revert of
#1067 #1067.


Reply to this email directly or view it on GitHub
#1126 (comment).

@phansys
Copy link
Contributor Author

phansys commented Aug 30, 2014

Done.

@Ocramius Ocramius self-assigned this Aug 30, 2014
Ocramius added a commit that referenced this pull request Aug 30, 2014
Fixed new line in docblock
@Ocramius Ocramius merged commit 6e34985 into doctrine:master Aug 30, 2014
@Ocramius
Copy link
Member

@phansys thanks!

@phansys
Copy link
Contributor Author

phansys commented Aug 30, 2014

Thank you @Ocramius.

@albertvolkman
Copy link

This also removes the fullstop unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants