Improve static analysis on AttachEntityListenersListener #11272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$listenerCallback is supposed to be a method name, so it is safe to require it is not a falsy string.
greg0ire
commented
Feb 19, 2024
| * @param class-string $entityClass The entity to attach the listener. | ||
| * @param class-string $listenerClass The listener class. | ||
| * @param Events::*|null $eventName The entity lifecycle event. | ||
| * @param non-falsy-string|null $listenerCallback The listener callback method or NULL to use $eventName. | ||
| */ | ||
| public function addEntityListener( |
There was a problem hiding this comment.
Note: it's unclear to me who/what calls this method. The class is not referenced at all in src, but it is referenced in the Symfony bundle. I suspect the method might only be there for test purposes. That class was introduced in #850
There was a problem hiding this comment.
Possible. I remember when entitylisteners could only be configured with annotations in the entity class itself and there was no way to inject dependencies into the listener's constructor.
SenseException
approved these changes
Feb 19, 2024
| * @param class-string $entityClass The entity to attach the listener. | ||
| * @param class-string $listenerClass The listener class. | ||
| * @param Events::*|null $eventName The entity lifecycle event. | ||
| * @param non-falsy-string|null $listenerCallback The listener callback method or NULL to use $eventName. | ||
| */ | ||
| public function addEntityListener( |
There was a problem hiding this comment.
Possible. I remember when entitylisteners could only be configured with annotations in the entity class itself and there was no way to inject dependencies into the listener's constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve static analysis on AttachEntityListenersListener
$listenerCallbackis supposed to be a method name, so it is safe torequire it is not a falsy string.