Fix sqlWalker::walkSimpleArithmeticExpression phpdoc #11298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with ORM 2 & 3 is not always easy with the different phpdoc/typehint on SQLWalker (and static analysis).
walkSimpleArithmeticExpression
phpdoc only acceptsSimpleArithmeticExpression
on 2.x but in fact support a wilder type Node|string ; and the type was updated on 3.x branch.I took the typehint from the 3.x branch
orm/src/Query/SqlWalker.php
Line 2127 in 2a250b5
This also fixes 7 baselines entries