Performance Optimization for computing id hashes. #11316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 09b4a75 we introduced an API
UnitOfWork::getIdHashByIdentifier
that added a significant amount of function calls over the previous inlineimplode
to support backed enums as identifiers.This PR moves ID hashing into a strategy pattern, moving the object to
ClassMetadata
instances of each entity, getting the previous performance almost back (+ the dynamic call).I hope this will significantly improve performance of the 80% identifier that is a simple, single numeric identifier.
Here are the results from two traces compaed with Tideways using the lazy ghost performance project discussed in #11087 that runs
EntityManager::getReference
, hitting the ID hashing code significantly for 100.000 objects.UnitOfWork::getIdHashByIdentifier
SingleElementIdHashing::getIdHashByIdentifier
UnitOfWork::tryGetById
UnitOfWork::tryGetByIdWithClass
While not life-changing, this hit accrues, especially in test-suites working with fixtures.