[Documentation] Query Result Formats #11372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/dql-doctrine-query-language.html#query-result-formats Follow-up of doctrine#11359 The table I suggested is probably not working, since the text for each method is too long. And what I really wanted is to make it more *scanable*. So I tried boldfacing - if this doesn't work, I'll try something else. Questions: 1. This section here is basically the same as https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/dql-doctrine-query-language.html#hydration-modes ! So I'll try to merge them (in another PR), OK? I think the list is a better format (more scanable) - since those methods all work the same, there's no need for a full-blown code sample for each, IMO. 2. `getSingleColumnResult()` is missing.
|
greg0ire
reviewed
Mar 21, 2024
| it leads to more concise code. | ||
| In parentheses are the constants of the ``Query`` class which you can use with the | ||
| general-purpose method ``Query::execute(array $params = [], $hydrationMode = Query::HYDRATE_OBJECT)``. | ||
| In fact, the recommended methods in the list are just convenient shortcuts for the hydration mode. |
There was a problem hiding this comment.
This phrasing is a bit clumsy I think, it implies the list contains some methods that are recommended, and some methods that are not.
There was a problem hiding this comment.
Yeah, clumsy, indeed! I now deleted "recommended": Since using the method is shorter than using the constant, people will go for it anyway - so no need to explicitly recommend it :-)
greg0ire
approved these changes
Mar 21, 2024
SenseException
approved these changes
Mar 22, 2024
|
Thanks @ThomasLandauer ! |
ThomasLandauer
added a commit
to ThomasLandauer/orm
that referenced
this pull request
Mar 26, 2024
Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/dql-doctrine-query-language.html#query-result-formats As announced in doctrine#11372 (comment), I merged the (mostly) identical sections. * I changed the `const`s from `Query` to `AbstractQuery` * I deleted this - mainly cause I didn't find a nice place for it: > In parentheses are the constants of the ``Query`` class which you can use with the general-purpose method ``Query::execute(array $params = [], $hydrationMode = Query::HYDRATE_OBJECT)``.
ThomasLandauer
added a commit
to ThomasLandauer/orm
that referenced
this pull request
Mar 27, 2024
Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/dql-doctrine-query-language.html#query-result-formats As announced in doctrine#11372 (comment), I merged the (mostly) identical sections. * I changed the `const`s from `Query` to `AbstractQuery` * I deleted this - mainly cause I didn't find a nice place for it: > In parentheses are the constants of the ``Query`` class which you can use with the general-purpose method ``Query::execute(array $params = [], $hydrationMode = Query::HYDRATE_OBJECT)``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/dql-doctrine-query-language.html#query-result-formats
Follow-up of #11359
The table I initially suggested is probably not working, since the text for each method is too long. And what I really wanted is to make it more scanable. So I tried boldfacing - if this doesn't work, I'll try something else.
Questions:
This section here is basically the same as https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/dql-doctrine-query-language.html#hydration-modes ! So I'll try to merge them (in another PR), OK? I think the list is a better format (more scanable) - since those methods all work the same, there's no need for a full-blown code sample for each, IMO.
getSingleColumnResult()is missing.For
getSingleResultandgetOneOrNullResultI couldn't find out theconst