Allow classname in 'value' attribute of xml discriminator-mapping field #11453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
May 15, 2024
|
|
||
| class CustomerType | ||
| { | ||
| public $name; |
There was a problem hiding this comment.
Let's declare string here, or directly use constructor property promotion
There was a problem hiding this comment.
PHPStorm gives these errors:
Typed properties are only allowed since PHP 7.4
Constructor property promotion is only allowed since PHP 8.0
Composer.json
"require": {
"php": "^7.1 || ^8.0",
...,
}
MatteoFeltrin
force-pushed
the
allow-fqcn-in-value-attribute-of-discriminator-mapping
branch
from
9e2c8cf to
73e30df
Compare
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
greg0ire
approved these changes
Oct 15, 2024
SenseException
approved these changes
Oct 15, 2024
|
Thanks @MatteoFeltrin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11449
In relation to #10630
This PR allows a more loosen validation of the value attribute of discriminator-mapping field, using orm:type in the XSD schema as it was done in the linked pull request.
The test I wrote loads the entity enabling the validation against XSD schema, thus expects no exception to be thrown.