Precise EntityRepository::count return type

[VincentLanglet]

Such PR was introduced on PHPStan side https://github.com/phpstan/phpstan-doctrine/pull/604/files

Either it's false, either it's true and should be directly added to the ORM code.
I already saw multiple @psalm-return 0|positive-int occurences, so I used the same syntax.

Psalm does not understand that in the BasicEntityPersister, 'SELECT COUNT(*) ... returns a positive int ; should I add the error to the baseline or typehint the result in a temporary variable ? (WDY prefer @greg0ire)

[derrabus]

The static analysis failures appear to be related to your changes.

[VincentLanglet]

The static analysis failures appear to be related to your changes.

Sure, it's because

return (int) $this->conn->executeQuery($sql, $params, $types)->fetchOne();

is not inferred as int<0, max but it is.

I have two ways to solve this.

1. Writing

/** @psalm-var 0|positive-int $count */
$count = (int) $this->conn->executeQuery($sql, $params, $types)->fetchOne();

return $count;

2. Adding the error to the baseline.

I wanted to know if you preferred one. I went with the first one. @derrabus

[greg0ire]

I think you picked the right solution, because the baseline is not made only of issues we deliberately want to ignore, but also of issues we might want to address someday ™️

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

Also, this should be targeted to 3.3.x.

[derrabus]

We could also assert($count >= 0);. WDYT?

[derrabus]

👍 once PHPCS is happy.

[VincentLanglet]

👍 once PHPCS is happy.

Done