Add CI job for PHP 8.4 #11631
Merged
Add CI job for PHP 8.4 #11631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now doctrine/common generates proxies that trigger deprecation, so let us only test with lazy ghosts only.
SenseException
previously approved these changes
Oct 8, 2024
|
Nice, that it seems to work with PHP 8.4 out of the box. |
derrabus
approved these changes
Oct 8, 2024
|
Shall we target 2.19? |
derrabus
previously approved these changes
Oct 8, 2024
|
We need to release 2.20 with a more undeprecations in the next few days anyways, so 2.20 for me is fine. |
E_STRICT is deprecated as of PHP 8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: