Remove vendor prefix of PHPDoc referencing class-string #11643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Oct 9, 2024
derrabus
force-pushed
the
improvement/class-string-in-unprefixed-phpdoc
branch
from
0c05824 to
a24a350
Compare
derrabus
force-pushed
the
improvement/class-string-in-unprefixed-phpdoc
branch
from
a24a350 to
61775dd
Compare
greg0ire
approved these changes
Oct 9, 2024
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Remove vendor prefix of PHPDoc referencing class-string (doctrine#11643) Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()` method (doctrine#11641)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Remove vendor prefix of PHPDoc referencing class-string (doctrine#11643) Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()` method (doctrine#11641)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 3.3.x: Remove vendor prefix of PHPDoc referencing class-string (doctrine#11643) Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker()` method (doctrine#11641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By now, all static analyzers and IDEs should know what a
class-string<Something>means, so let's remove the vendor prefix in those cases.