Check hint value before considering instance read-only

[pbreteche]

Documentation suggests that HINT_READ_ONLY accept a boolean value.
https://www.doctrine-project.org/projects/doctrine-orm/en/3.3/reference/improving-performance.html#read-only-entities

But UnitOfWork only check if hint is set to register new Entity instance as read-only.

Using the value parameter will code more consistent to documentation.

[greg0ire]

It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those.

[greg0ire]

Does this affect 2.x? If yes, please retarget to 2.20.x, and we will merge it up. Also, it would be nice to have a test covering this, inside tests/Tests/ORM/Functional/ReadOnlyTest.php

[pbreteche]

@greg0ire thanks for reviewing. Retargeting is done with one unit test.

[greg0ire]

Please improve your commit message according to the contributing guide.

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

1. git rebase -i origin/2.20.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
2. A window will show up with many lines, replace pick with fixup on every line but the first one
3. Close your editor, git should do its magic, and you should end up with one commit
4. Use git push --force to overwrite what you already pushed. Don't forget the --force option otherwise git will try to merge both things together.

[pbreteche]

Thanks for your patience. I'm not used to contributing to open-source projects .
Hoping this commit message is more meaningful.

[greg0ire]

And thanks for bearing with me, the new commit message is 👌