Test quoted qualified name

[greg0ire]

The current behavior is that a quote in the table name should result in the name being considered "quoted" and be passed to DBAL's quoteIdentifier() method, which should quote each identifier individually (so the dot is still interpreted as a schema separator).

This is prompted by doctrine/dbal#6590: let's make sure we don't break the current behavior when addressing the deprecation.

[morozov]

Not sure how to interpret the "even when quoted" clause. When the identifiers are unquoted, then it's not clear if the dot is part of the unqualified name or it's a delimiter between the qualifier and the unqualified name. With quoted identifier, it's clear that these are individual identifiers.

[greg0ire]

Oh, right, I lost track of the goal while trying to get to something that passes the tests, but I think the test might be pointless. At first, I tried using ticks around the whole name, like so:

`inventory.Products`

My goal was to demonstrate that we would still get an inventory schema, and not an inventory.Products table in the public schema even if the name was quoted (with backticks, as documented here). It didn't work out, and I noticed that the schema and the table name got separated before getting to this method:

orm/src/Mapping/DefaultQuoteStrategy.php

Lines 38 to 40 in cf39e00

	$tableName = $class->table['name'];
	if (! empty($class->table['schema'])) {

As specified here:

orm/src/Mapping/ClassMetadata.php

Lines 409 to 418 in cf39e00

	* @phpstan-var array{
	* name: string,
	* schema?: string,
	* indexes?: array,
	* uniqueConstraints?: array,
	* options?: array<string, mixed>,
	* quoted?: bool
	* }
	*/
	public array $table;

[morozov]

I see. I think, the upshot of this is that historically both ORM and DBAL didn't respect the semantics of quoted identifiers in full. Specifically, when parsing names. Quoted identifiers are/were only used to represent the names that are keywords (to render them as quoted in SQL). It was the user's responsibility to quote keywords like "table".

It looks like it's impossible at this moment (in neither of ORM and DBAL) to define a name that contains a dot. It will be always interpreted as a delimiter between identifiers.