improved error handling for invalid association values #2

[flip111]

Possibly to do:

1. Make custom Exception for line 713
2. Make custom Exception for line 817
3. Does the object check on line 816 slow down the code too much? Alternatively a try-catch could be put around line 1415 or higher up.

Previous: #1016

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3490

We use Jira to track the state of pull requests and the versions they got
included in.

[Ocramius]

Don't catch a generic exception here: be specific

[flip111]

Not sure how i can track all the possible situations which yield all possible Exceptions

[Ocramius]

@flip111 writing these tests isn't that problematic if you keep the test asset as simple as possible.

[Ocramius]

@flip111 also, please provide tests for this enhancement

[flip111]

@Ocramius i totally lost track (since 10 months) how i even arrived at this situation where this error would be useful. I hope not to forgot the PR this time though ^^

[Ocramius]

@flip111 the original PR was probably trying to give a better meaning to stuff like:

class Foo
{
    /** @ManyToOne(targetEntity="Bar") */
    public $bar;
}

$foo = new Foo;

$foo->bar = 'baz'; // wrong - exception
$foo->bar = []; // wrong - exception
$foo->bar = new ArrayCollection; // wrong - exception
$foo->bar = new stdClass; // wrong - exception
$foo->bar = new Bar; // correct

[fprochazka]

I would strongly discourage you from writing code in github editor. Checkout the branch and fix it locally. It's more effective and IDE tells about problems github won't.

[Ocramius]

This was manually rebased/tested and merged into master at 39766e6

Thanks @flip111!

[flip111]

Thank you @Ocramius i had already a hard time imagining being able to finish this PR

[Ocramius]

@flip111 check the merge commit, the test was not that terrible after all :-)

[flip111]

Ye i know it's not a big change. Just that Doctrine internal code is pretty hard to get into. I guess that goes for any ORMs though..

I checked the commit, you added two cases on the 2000+ lines, that's nice. I remember when i was testing i needed that catch around line 710 ... perhaps that has changed by now.

[Ocramius]

@flip111 yeah, the association exception throwing was enough :-)