Include className in calls to NamingStrategy joinColumnName method #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3496 We use Jira to track the state of pull requests and the versions they got |
|
@jacksleight this requires relevant test cases with an example naming strategy using this sort of API addition. |
|
Apologies for missing those. I have now included an example naming strategy class that makes use of this feature ( |
Ocramius
added a commit
that referenced
this pull request
Jan 17, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 17, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 17, 2015
|
Merged manually after reverting the signature BC break. I also moved the newly introduced class to the test suite dir. Thanks @jacksleight!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with
propertyToColumnName, include the class name when generating names for join columns as well, for instances where you want to name columns (inc. join columns) based on the class that defined them.