Fix applying ON/WITH conditions to first join in Class Table Inheritance

[vitaliyberdylo]

Now we build nested joins for CTI when using ON/WITH clause.

[doctrinebot]

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DDC-3500

We use Jira to track the state of pull requests and the versions they got
included in.

[vitaliyberdylo]

Hello @Ocramius.
You have already discussed this issue with my colleague
https://twitter.com/ato0n1/status/541754890499145728
Merge this PR as quickly as possible please.
Thank you.

[Ocramius]

@vitaliyberdylo can you add a functional test involving a JTI?

Ping @guilhermeblanco since you already handled this issue once before, IIRC.

[guilhermeblanco]

@Ocramius I didn't... it was required to implement precedence of joins (which is what this patch does for JTI) and I left aside.

[vitaliyberdylo]

Hello @Ocramius.
Do i need to do something like this https://github.com/doctrine/doctrine2/pull/668/files?
It PR must be into master and 2.4 or only 2.4?

[Ocramius]

@vitaliyberdylo this will go in 2.5 for now, and may be backported later on

[Ocramius]

I could also need a test case with a DQL query actually producing failing previously to this patch.

Should be doable with some of the existing test assets.

[guilhermeblanco]

@Ocramius that's only the tip of the iceberg... if we go down the precedence of joins path, we should also properly address whatever got listed in http://www.doctrine-project.org/jira/browse/DDC-349

[Ocramius]

This PR is already applied to master, therefore only merging into 2.4.

[Ocramius]

Thanks @vitaliyberdylo!

[vitaliyberdylo]

Thank you guys!