LimitSubqueryOutputWalker: fix aliasing of property in OrderBy from MappedSuperclass

[fprochazka]

http://www.doctrine-project.org/jira/browse/DDC-3679

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3680

We use Jira to track the state of pull requests and the versions they got
included in.

[billschaller]

Thanks - i'll merge after nitpick 👍

[fprochazka]

I'm not sure if it's fixed properly. Is this enough?

[billschaller]

@fprochazka I think so - though there's no functional test for this case...

[fprochazka]

@zeroedin-bill now I'm thinking it might be better to reverse the condition and only change the alias if the entity is in inheritance and it's the type of inheritance where you use multiple tables. Because it still might break with STI. Somebody might wanna write tests for that.

[billschaller]

@fprochazka we need more functional test cases...

[fprochazka]

Sure, there is never enough tests :) But I won't be able to write more right now. Soonest would be somewhere around monday and I can't promise that.

[billschaller]

@fprochazka For now I'll merge this. I'd really appreciate if you could write some functional tests on Monday to cover this scenario if you have time!

Thanks!

[fprochazka]

I'll try!