-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Upgrade.md after minor bc break in 2.5.0 #1529
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3938 We use Jira to track the state of pull requests and the versions they got |
@tkleinhakisa I think the BC break should be reverted, and we should use |
@Ocramius I thiink i made a mistake and the break was introduced in 2.5.0 not 2.5.1 In this case the param should be kept and the upgrade 2.5 updated, is that right ? |
@tkleinhakisa if the BC break happened from 2.4.x -> 2.5.0 then this patch is correct, and no reverting is needed. |
@@ -1,3 +1,9 @@ | |||
# Upgrade to 2.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to the 2.5
block
The introduction of the second parameter in EntityRepository#createQueryBuilder generates a runtime notice if you have a sub-class of EntityRepository that has a second parameter in the createQueryBuilder method
05538fa
to
8535e01
Compare
Fixed and rebased |
Update Upgrade.md after minor bc break in 2.5.0
Thanks for the PR! This is now merged in 2.5 and master branches. |
The introduction of the second parameter in EntityRepository#createQueryBuilder generates a runtime notice if you have a sub-class of EntityRepository that has a second parameter in the createQueryBuilder method
The parameter was introduced in b0513a7