Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 3.0 components on 2.5 #1543

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Allow symfony 3.0 components on 2.5 #1543

merged 1 commit into from
Nov 9, 2015

Conversation

nicolas-grekas
Copy link
Member

So that doctrine 2.5 can be used with symfony 3.0.

Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DDC-3978

We use Jira to track the state of pull requests and the versions they got
included in.

@Koc
Copy link
Contributor

Koc commented Nov 5, 2015

@nicolas-grekas should travis also to be changed for testing with 3.0 components?

@nicolas-grekas
Copy link
Member Author

Not sure it's worth it, symfony/console didn't change that much in 3.0, and since 2.8 is tested, any change should already be reported with deprecation notices. Here, tests tell us than none applies, thus it will work in 3.0.

@guilhermeblanco guilhermeblanco self-assigned this Nov 9, 2015
guilhermeblanco added a commit that referenced this pull request Nov 9, 2015
Allow symfony 3.0 components on 2.5
@guilhermeblanco guilhermeblanco merged commit 1d213e6 into doctrine:2.5 Nov 9, 2015
@guilhermeblanco
Copy link
Member

I thought I had merged this last week! =(

@nicolas-grekas nicolas-grekas deleted the dep-30 branch November 9, 2015 22:11
@nicolas-grekas
Copy link
Member Author

you merged it on master, this 2.5 now :) thanks!

@wouterj
Copy link
Contributor

wouterj commented Nov 18, 2015

@guilhermeblanco can this please be included in a new 2.5 release, so we can finish 3.0 support for the DoctrineBundle? (doctrine/DoctrineBundle#486)

@Ocramius
Copy link
Member

Can probably do a release over the weekend

@dbu
Copy link
Member

dbu commented Nov 23, 2015

@Ocramius you meant the last weekend, right? :-P would be great if you can find a moment to release a 2.5 so we can move on with DoctrineBundle.

@Ocramius
Copy link
Member

Preparing release notes now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants