-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symfony 3.0 components on 2.5 #1543
Conversation
Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0
Hello, thank you for creating this pull request. However did not open it on the "master" Please open the pull request again for the "master" branch and close Nevertheless I have opened a Jira ticket for this Pull Request to track this http://www.doctrine-project.org/jira/browse/DDC-3978 We use Jira to track the state of pull requests and the versions they got |
@nicolas-grekas should travis also to be changed for testing with 3.0 components? |
Not sure it's worth it, symfony/console didn't change that much in 3.0, and since 2.8 is tested, any change should already be reported with deprecation notices. Here, tests tell us than none applies, thus it will work in 3.0. |
Allow symfony 3.0 components on 2.5
I thought I had merged this last week! =( |
you merged it on master, this 2.5 now :) thanks! |
@guilhermeblanco can this please be included in a new 2.5 release, so we can finish 3.0 support for the DoctrineBundle? (doctrine/DoctrineBundle#486) |
Can probably do a release over the weekend |
@Ocramius you meant the last weekend, right? :-P would be great if you can find a moment to release a 2.5 so we can move on with DoctrineBundle. |
Preparing release notes now |
So that doctrine 2.5 can be used with symfony 3.0.