[DCOM-93] Remove Reflection dependency from ClassMetadata #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taFactory#wakeupReflection to ClassMetadataInfo#wakeupReflection
…nitializeReflection
… moving all the code into ClassMetadataInfo for BC reasons.
| * @param ReflectionSErvice $reflService | ||
| * @return void | ||
| */ | ||
| protected function initializeReflection(ClassMetadataInfo $class, ReflectionService $reflService) |
There was a problem hiding this comment.
shouldn't you typehint the interface (as done in the phpdoc) ?
beberlei
added a commit
that referenced
this pull request
Jan 3, 2012
[DCOM-93] Remove Reflection dependency from ClassMetadata
This was referenced Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reflection dependency leads to the annoying problem that we have the ClassMetadata deriving from ClassMetadataInfo. This is very bad OO code and has lead to problems on multiple occasions.
This PR removes the dependency by injecting a reflection service, which can be a Static Service not requiring the classes to exist.