Use cascade=all if all cascade options set #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
| @@ -99,6 +99,9 @@ public function exportClassMetadata(ClassMetadataInfo $metadata) | |||
| unset($cascade[$key]); | |||
| } | |||
| } | |||
| if (count($cascade) === 5) { | |||
| $cascade = array('all'); | |||
| } | |||
There was a problem hiding this comment.
Please add an empty line before and after the if block
|
Added empty lines around if block and removed trailing whitespace |
beberlei
added a commit
that referenced
this pull request
Oct 5, 2012
Use cascade=all if all cascade options set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML and XML metadata exporters output cascade=all if all five cascade options are set. The php and annotation exporter do not, they output cascade=list of all 5 cascades instead.
In order that all 4 exporters offer the same behavior, I updated the php and annotations exporters so that they export cascade=all