Use protected so EntityGenerator can be extended

[ethanresnick]

This is definitely something I'd like to be able to extend, and I imagine others might too.

[doctrinebot]

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2062

[zczapran]

Wouldn't it be better to create an interface and make the EntityGenerator implement it?

[ethanresnick]

I don't think so. I mean, we could have an interface too, but the issue isn't so much that all EntityGenerator's needs to present the same methods to some other cooperating class.

The problem is that if I want to make tweaks to how generation works, I have to reimplement (read: copy and paste) the existing functionality into a new class and then make my tweaks there, rather than just subclassing the existing class.

[stof]

@beberlei it may be time to complete your CodeGenerator project and migrate the EntityGenerator to it :)

[zczapran]

Some of the private (protected) methods (especially the ones that are complicated, like generateAssociationMappingPropertyDocBlock) could be moved into separate components and the EntityGenerator could be parametrized by injecting those components (composition over inheritance principle). It's a big refactoring work to be done but it might be worth it.

Anyway in a short term your approach is fine.

[ethanresnick]

@stof @beberlei Hadn't seen that project before. Looks awesome.

[stof]

@ethanresnick the goal is to rewrite the EntityGenerator entirely based on it.

[beberlei]

I will merge this as I have no defined roadmap when i will finish the code generator replacement.

[ethanresnick]

Sounds good. Thanks!