Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed problems with joined inheritance and composite keys #537

Merged
merged 2 commits into from
May 4, 2013
Merged

fixed problems with joined inheritance and composite keys #537

merged 2 commits into from
May 4, 2013

Conversation

Powerhamster
Copy link
Contributor

SchemaTool now creates all Id columns not just only the first one.
Insert statement for child entity now contains parameter for additional key columns only once.

SchemaTool now creates all Id columns not just only the first one.
Insert statement for child entity now contains parameter for additional key columns only once.
@doctrinebot
Copy link

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2201

added tests for single table inheritance
@beberlei
Copy link
Member

beberlei commented Jan 6, 2013

  1. What is the problem?
  2. What does your solution attempt to fix?
  3. Is the schema changed by this?

If the answer to 3 is yes, then this PR is an unacceptable backwards compatible break and cannot be merged at all. I would like to try to understand what problem you see in the current implementation and help you with that instead.

@Powerhamster
Copy link
Contributor Author

I am using entities with composite keys. By using joined inheritance I discovered that only the first id column becomes part of the derived table. This has been fixed, so that now all id columns are created correctly.
All this id columns become now part of one foreign key contraint.

There should be no backwards compatibilty break. Usage of composite keys with joinded inhertitance doesn't work, so it can't be used be someone. The fix has no effect to inheritance with only a single pk column. This should work as before.

@beberlei
Copy link
Member

beberlei commented Jan 6, 2013

Ok, I understand the issue better now, thanks for the clarification

beberlei added a commit that referenced this pull request May 4, 2013
fixed problems with joined inheritance and composite keys
@beberlei beberlei merged commit 8e8560b into doctrine:master May 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants