Fixed ObjectHydrator when namespace alias is given.

[beregond]

Fixes problem when executing native query:

$rsm = new ResultSetMapping();

$rsm->addEntityResult('DbBundle:Player', 'p');
$rsm->addFieldResult('p', 'id', 'id');
$rsm->addFieldResult('p', 'name', 'name');

$rsm->addJoinedEntityResult('DbBundle:User', 'u', 'p', 'user');
$rsm->addFieldResult('u', 'user_id', 'id');

$em->createNativeQuery('...', $rsm);

Hydrator couldn't find cached metadata, when "joined entity result" class name wasn't fully qualified name (as in the example above).

[doctrinebot]

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2256

[Ocramius]

@beregond please add the failing test for this problem.
Also, I think this should be simply added in addEntityResult and addJoinedEntityResult to avoid performance drawbacks.

[norberttech]

I'm not sure about this line.
If $className have ":" then _ce cache is useless because Entity Manager will be called every single time when this line is executed.

[beregond]

Well it's pain, but don't see other way now to make sure we have fully qualified name of class.

[beregond]

I wrote test and found out other place that need to fix. Best way is to translate namespace alias in ResultSetMapping, but is that somehow possible?

[beberlei]

We actually didn't support this for performance reasons (it affects the normal DQL queries too), but I see value in adding this for user convience. However i think the location is wrong. Rather than doing it in the hydration process, the Query object should actually fix a RSM when its set. This way we keep the transformation at the source.

[beregond]

I've fixed test and added case for ResultSetMappingBuilder which has same problem.

This way it's now allows to translate namespaces whithout breaking BC.

[Ocramius]

Can completely be simplified into:

$em->getClassMetadata($alias)->getName()

The metadata factory already handles namespaces. No need for additional function calls

[beregond]

Well I think it's important to check if it's namespace alias for sure, so we can have temporary mapping in $fqcn like:

$fqcn = array(
    'AcmeBundle:User' => 'Acme\SomeBundle\Entity\User',
    'AcmeBundle:Group' => 'Acme\SomeBundle\Entity\Group',
);

so we won't have to get metadata each time 'AcmeBundle:User' occurs. In fact I could remake three lines below to form:

$fqcn[$alias] = $em->getClassMetadata($alias)->getName();

[Ocramius]

You can just keep the map (not the strpos check)

[stof]

this curly brace should be on the previous line