Fix issue where xml mapping cannot find file on certain configurations #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0% due to less serialization/deserialization
…Persistence::getSelectJoinColumnSQL()
…on of EntityGeneratorTest. No explanation why it iss failing yet
… embeddeds and discriminator columns to hold its owning table name.
… be brought back with proper implementation
…sing checks for discriminator column and version column.
…ear($entityClass), clear($proxyClass), clear($rootOfInheritance)
|
This needs a test case. |
Ocramius
suggested changes
Jan 25, 2017
| @@ -911,7 +911,8 @@ private function getCascadeMappings(SimpleXMLElement $cascadeElement) | |||
| protected function loadMappingFile($file) | |||
| { | |||
| $result = []; | |||
| $xmlElement = simplexml_load_file($file); | |||
| $xmlData = file_get_contents($file); | |||
phansys
suggested changes
Feb 1, 2017
| @@ -911,7 +911,7 @@ private function getCascadeMappings(SimpleXMLElement $cascadeElement) | |||
| protected function loadMappingFile($file) | |||
| { | |||
| $result = []; | |||
| $xmlElement = simplexml_load_file($file); | |||
| $xmlElement = simplexml_load_string(file_get_contents($file)); | |||
There was a problem hiding this comment.
Is there any situation where simplexml_load_file() is not returning false with a not found file?
There was a problem hiding this comment.
Is there any situation where
simplexml_load_file()is not returningfalsewith a not found file?
Indeed, that's what a test would verify, but I see no tests.
|
This is related to #3788. |
guilhermeblanco
force-pushed
the
develop
branch
from
daf5c17 to
3fabe0d
Compare
|
@mistraal can you please rebase with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to this issue and this issue.
While this is a very specific case, it is not exclusive to Nginx server as it also happens on my Apache setup.