-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added abillity to use metacolumn as indexBy #639
Conversation
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
@@ -255,5 +255,18 @@ public function testAddNamedNativeQueryResultClass() | |||
$this->assertEquals('Doctrine\Tests\Models\CMS\CmsUser', $rsm->getDeclaringClass('status')); | |||
$this->assertEquals('Doctrine\Tests\Models\CMS\CmsUser', $rsm->getDeclaringClass('username')); | |||
} | |||
public function testIndexByMetadataColumn() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CS - missing newline before this line
@goetas except for CS, this looks good to me |
@goetas in the testcase the indention is weird, and can you add a functional test as well? There is a testcsae which has lots of |
Added more tests |
Added abillity to use metacolumn as indexBy
Sorry for commenting on this closed PR. But a lot of people ask me about this feature recently. Should an example be added to the docs? /**
* @OneToMany(targetEntity="Stock", mappedBy="market", indexBy="market_id")
* @var Stock[]
*/
private $stocks; |
Added ability to use meta column as indexBy. Useful if association entities is widely used.
Replace #204 PR