Fixes #4252 Cascading refresh to lazy loaded assocations

[zluiten]

Fixes #4252
Closes #1218

Bug description

Refreshing an entity resets toMany (extra) lazy loaded associations to an empty collection before the refresh operation is cascaded to its underlying associations. Meaning objects that should be refreshed stay unrefreshed in the UoW.

Fix

The fix simply cascades the operation to its associations before refreshing the current entity.

[lcobucci]

@Netiul please change the destination branch to master and rebase your branch to sync all the changes. That's explained on https://github.com/doctrine/doctrine2/blob/master/CONTRIBUTING.md#we-only-accept-prs--to-master

[zluiten]

@lcobucci 👍 Fixed that.

[MaSpeng]

I also ran into this issue with an non updating ManyToMany association and this PR solves my issue.

@lcobucci @Netiul Whats about this PR is there any ongoing progress?

[FrankGiesecke]

@Netiul Could you resolve the conflicts please?

@lcobucci Please, continue to review this pull request and accept/merge it. Resolving this problem will make many happy developers out there 😉

[zluiten]

@FrankGiesecke Rebased on master Rebased on 2.6 after reading updated contribution instructions @lcobucci

[juliolopeztorres]

Any news regarding this issue?

I'm facing the same problem as cascade={"refresh"} only refreshes parent entity from oneToMany relation.

I have to manually refresh the Collection as mentioned in this post.

[yapro]

I have the same problem, cascade={"refresh"} declaration, refresh only parent entity from oneToMany relation.

[angelomelonas]

I am also facing this issue. This is probably not the best solution, but current workaround I use is:

    private function refreshCollection(Collection $collection): Collection
    {
        foreach ($collection as $item) {
            $this->entityManager->refresh($item);
        }

        return $collection;
    }

[timrasche]

News on this?

[zluiten]

Rebased on 2.11.x

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[zluiten]

I believe it's still relevant

[greg0ire]

Looks like this was handled in #10065 🙂