Clear visitedCollections

[shulcsm]

Visited collections are cleared only in commit(). Commit clears up only if it actually has something to do. Processing large amounts of records without changing them cause visitedCollections to grow without any way of clearing.

[stof]

could you add a test for this ?

[Ocramius]

@stof can't really test this one since there's no way to access the visited collections...

[beberlei]

This explains why some people have memory leaks even when using clear.

[beberlei]

@shulcsm have you tested that this is actually the case in visitedCollections. I can't come up with a flow diagram of how this state is actually reached. The property is only set, when you call flush on the EntityManager.

[shulcsm]

@beberlei
Early return point here https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L315 cause this.

To reproduce:

1. Select existing entity
2. Add new associated entities
3. Remove associated entities
4. Flush (There are no actual data, so commit returns at L315 without reaching the clear at L381)
5. Clear
   uow should be empty, visitedCollections are still there.