Color message like the update tools #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2559 We use Jira to track the state of pull requests and the versions they got |
| $output->writeln(sprintf('The Schema-Tool would execute <info>"%s"</info> queries to update the database.', count($sqls))); | ||
| $output->writeln('Please run the operation by passing one - or both - of the following options:'); | ||
|
|
||
| $output->writeln(sprintf(' <info>%s --force</info> to execute the command', $this->getName())); |
There was a problem hiding this comment.
Doesn't this already work with <CLI> help orm:schema-tool:drop ? Seems like a repetition here...
There was a problem hiding this comment.
In fact, this is the same message, but with color around "num" queries, and options.
Without this PR,
DropCommand & UpdateCommand display the same content, but the presentation isn't the same..
|
Right now, the CLI is like that :
|
|
Enough running around such a trivial one: goes in :) |
Ocramius
added a commit
that referenced
this pull request
Jul 22, 2013
Color message like the update tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.