Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing hint about lifecycle callback #729

Merged
merged 1 commit into from
Aug 10, 2013
Merged

add missing hint about lifecycle callback #729

merged 1 commit into from
Aug 10, 2013

Conversation

dbu
Copy link
Member

@dbu dbu commented Jul 22, 2013

the hint that this event is not also a lifecycle callback was missing for two of the event types.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2561

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

@dbu what about dividing them into 2 sections "events" and "lifecycle events" ?

@dbu
Copy link
Member Author

dbu commented Jul 22, 2013

sure, would make sense to clean up the doc here and make it more clear.
but i don't have time to do that, so i thought to at least make it correct.

beberlei added a commit that referenced this pull request Aug 10, 2013
add missing hint about lifecycle callback
@beberlei beberlei merged commit acb7dfb into doctrine:master Aug 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants