Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy performance test #735

Merged

Conversation

FabioBatSilva
Copy link
Member

No description provided.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2573

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

@FabioBatSilva what was going on here?

@FabioBatSilva
Copy link
Member Author

@Ocramius The MockEntityManager gives a null MetadataFactory and crashes AbstractProxyFactory constructor : https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L72

@Ocramius
Copy link
Member

Ah, forgot that travis doesn't run performance tests, so I was looking in
the wrong place :)
On 27 Jul 2013 03:36, "Fabio B. Silva" [email protected] wrote:

@Ocramius https://github.com/Ocramius The MockEntityManager gives a
null MetadataFactory and crashes AbstractProxyFactory constructor :
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Proxy/ProxyFactory.php#L72


Reply to this email directly or view it on GitHubhttps://github.com//pull/735#issuecomment-21657080
.

guilhermeblanco added a commit that referenced this pull request Jul 27, 2013
@guilhermeblanco guilhermeblanco merged commit eea8572 into doctrine:master Jul 27, 2013
@FabioBatSilva FabioBatSilva deleted the fix-proxy-performance-test branch July 29, 2013 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants