-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified Hydrators to be per-query instances instead of a singleton-like approach #738
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2578 We use Jira to track the state of pull requests and the versions they got |
@guilhermeblanco was removing API necessary here? |
@Ocramius it was not used anywhere else. |
Yes, but it's in an interface...
|
@Ocramius which got created only on master because of EntityManagerDecorator (one of my modified files). |
Ah, wasn't aware of that. Nothing to argue about then :)
|
@@ -224,14 +224,6 @@ public function getUnitOfWork() | |||
/** | |||
* {@inheritdoc} | |||
*/ | |||
public function getHydrator($hydrationMode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a BC break, people are using this. You should delegate that call to newHydrator
.
@beberlei the API is not existing in 2.3.x. Would you still consider it a break since it's in the 2.4.x-RCy? |
@Ocramius err yes of course, BC breaks are only allowed in MAJOR versions, i.e. 2.* => 3.0 |
Modified Hydrators to be per-query instances instead of a singleton-like approach
This fixes an old issue we have where we have a Query that triggers an entity-specific postLoad event which attempts to do another Query.
In this situation, developer will face an "Attempt to call method on a null object" error on PHP.