[DDC-2655] Don't let getOneOrNullResult throw NoResultException #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2656 We use Jira to track the state of pull requests and the versions they got |
|
|
||
| use Doctrine\ORM\Query; | ||
|
|
||
| require_once __DIR__ . '/../../../TestInit.php'; |
There was a problem hiding this comment.
Can you remove this line? While many tests still have it, its actually not needed anymore.
|
Is this pull request now satisfactory? |
|
How's this looking, @beberlei? |
|
I combined the commits and rebased from the current master. Is anything wrong? |
|
This looks good to me. @guilhermeblanco @beberlei what do you think ? |
guilhermeblanco
added a commit
that referenced
this pull request
Oct 11, 2013
[DDC-2655] Don't let getOneOrNullResult throw NoResultException
This was referenced Dec 6, 2015
|
This was fixed long ago, shouldn't the ticket (and PR #3391) be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDC-2655