Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates while reading the basic-mapping page #786

Merged
merged 2 commits into from
Sep 13, 2013

Conversation

weaverryan
Copy link
Contributor

Hi guys!

This is just from a quick read-through of the basic-mapping page. Most changes are pretty minor :).

The only arguable changes involve a few spots where I either removed something I thought was too technical and not valuable (e.g. talking about the metadata mapping pattern).

Thanks!

The only arguable changes involve a few spots where I either removed something I thought was too technical and not valuable (e.g. talking about the metadata mapping pattern).
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2676

We use Jira to track the state of pull requests and the versions they got
included in.

@@ -4,12 +4,12 @@ Basic Mapping
This guide explains the basic mapping of entities and properties.
After working through this guide you should know:

- How to create PHP classes that can be saved in the database with Doctrine
- How to create PHP classes that can be saved to the database with Doctrine;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably PHP objects

@weaverryan
Copy link
Contributor Author

@Ocramius thanks! Tweaks made!

Ocramius added a commit that referenced this pull request Sep 13, 2013
Minor updates while reading the basic-mapping page
@Ocramius Ocramius merged commit c72698a into doctrine:master Sep 13, 2013
@Ocramius
Copy link
Member

@weaverryan thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants