Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DDC719Test.php to be compatible with MsSQL #787

Merged
merged 3 commits into from
Oct 7, 2013

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Sep 13, 2013

Apparently Doctrine adds "with (nolock)" now for the mssql platform, but the test has not been updated yet.

Apparently Doctrine adds "with (nolock)" now for the mssql platform, but the test has not been updated yet.
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2678

We use Jira to track the state of pull requests and the versions they got
included in.

@guilhermeblanco
Copy link
Member

Use a ternary to build reference SQL

@flip111
Copy link
Contributor Author

flip111 commented Sep 30, 2013

this one might be missing an extra new line at the end of the file.

@flip111
Copy link
Contributor Author

flip111 commented Sep 30, 2013

ternary will result in a very long line ... but that is ok for comparing two sql strings (according to guilhermeblanco)

@stof
Copy link
Member

stof commented Sep 30, 2013

A ternary can be multiline:

$sql = $condition
    ? '...'
    : '....';

@flip111
Copy link
Contributor Author

flip111 commented Sep 30, 2013

Yes stof, but we discussed this on IRC these are the notes. The argument is that multiline if/else looks better. But we will do ternary on a very long line ... this is in the case of comparing SQL strings

guilhermeblanco added a commit that referenced this pull request Oct 7, 2013
Update DDC719Test.php to be compatible with MsSQL
@guilhermeblanco guilhermeblanco merged commit ded3d20 into doctrine:master Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants