Improve docs: INSTANCE OF needs class metadata as parameter value

[flaushi]

…r value for the INSTANCE OF DQL expression

As discussed on slack and in relation to #6483, one could clarify in the docs that it's not enough to just bind a class name by its FQCN.

[malarzm]

it should be its as it's a possessive

[greg0ire]

Please squash your commits and please improve your commit message according to the contributing guide.

Also, please associate your email address with your Github account, or change the
email in your commits to an address already associated with it. If you do not
want to expose your personal email address, you may use
[email protected], that way we can still reach you through Github.
Additionally, you will get credit for this contribution on your Github profile.

[greg0ire]

Also, this should probably target 2.7 or 2.8.x otherwise your changes will not appear in the docs people actually read until 3.0 is released.

[flaushi]

@greg0ire Yes, that should be done of course. So should I create a new fork of the branch '2.7'?

[flaushi]

I applied my note to a branch basing on 2.7, and pushed it here https://github.com/flaushi/orm/tree/note-instance-of (commits squashed, email address changed)

Can you change the merge request or should I start a new one?

[greg0ire]

You can reset your master branch to note-instance-of and force push. It will be confusing, but I guess this is why you should not use master when making a PR. Once it is done, click the Edit button and change the target branch. Once this is merged, I recommend you delete your master branch, that way it will be hard for you to commit on it.

[flaushi]

I am too unexperienced with this git s**t. Argh, now I have all my messages twice 😩.
Can't I just open a new PR for the note-instance-of branch? I guess it's also better because it already targets 2.7?

[greg0ire]

Please just git checkout master && git reset --hard note-instance-of && git push --force

[flaushi]

I think that's it. One commit, with email address. Anything else required from my side? You spoke about merging...🤷‍♂️

[greg0ire]

Your commit does not seem to start from 2.7

[greg0ire]

If you can find your commit in the git history, try git reset --hard 2785cde && git cherry-pick d3209633abcd31a1f50346ec58065493130d1f68 && git push --force

[greg0ire]

I'm on the symfony-dev slack if you want to chat

[greg0ire]

It looks sane now :)

^

[cs278]

What's needed to get this merged?

[greg0ire]

One more approval I'd say.