-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add possibility to use sql comments in the DQL syntax #8140
Conversation
You can run |
Hi @greg0ire, I didn't use phpcbf because it made to many changes on the file. I just fixed the coding style by hand. I believe this phpcbf should be run outside this feature PR in this case. I added a documentation. Thanks for your feedbacks, |
You did well. I forgot we have this special behavior in this repo where we only fix CS for new code. |
LGTM |
Sorry @guilhermeblanco, but what does mean LGTM ? |
https://www.urbandictionary.com/define.php?term=LGTM :) (I don't think it's the sixth meaning, don't worry) |
Thanks @philippe-levan ! |
Thanks for the merge ! |
@greg0ire : do you want me to create the equivalent PR on master ? |
No don't worry, it will get merged up in time. |
Hi,
Sometimes I want to add sql comments in DQL queries. This PR adds the possibility to use comments in DQL.
Best regards,
Philippe