Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options not respected for ID Fields in XML Mapping Driver #816

Merged
merged 2 commits into from
Jan 2, 2014
Merged

Options not respected for ID Fields in XML Mapping Driver #816

merged 2 commits into from
Jan 2, 2014

Conversation

leggiero
Copy link

@leggiero leggiero commented Oct 9, 2013

Same bug of the YAML driver, see: http://www.doctrine-project.org/jira/browse/DDC-2661

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2732

We use Jira to track the state of pull requests and the versions they got
included in.

@FabioBatSilva
Copy link
Member

@Dudytz can you add a test case please ?

@leggiero
Copy link
Author

leggiero commented Oct 9, 2013

@FabioBatSilva I don't have a working dev environment for doctrine to create the test cases. This is the same bug that has been resolved only in the YAML driver. PS: this bug exists in all the branches (2.0, 2.1, 2.2, 2.3, 2.4 and master) in the YAML driver and XML driver.

@giosh94mhz
Copy link
Contributor

Please, backport this fix also on 2.3.*

@@ -350,6 +350,7 @@
<xs:element name="generator" type="orm:generator" minOccurs="0" />
<xs:element name="sequence-generator" type="orm:sequence-generator" minOccurs="0" maxOccurs="1" />
<xs:element name="custom-id-generator" type="orm:custom-id-generator" minOccurs="0" maxOccurs="1" />
<xs:element name="options" type="orm:options" minOccurs="0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxOccurs="1"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius I agree with you, since there should be one "options" node with multiple "option" children.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants