Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more accurate terminology #8236

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Aug 8, 2020

I think this was a mistake when writing this documentation, and that the
original author meant to use attribute here, columns do not have
columns, they have attributes.

Saw this while trying to understand #8234

I think this was a mistake when writing this documentation, and that the
original author meant to use attribute here, columns do not have
columns, they have attributes.
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. But did you mean another issue/PR? You're referencing this one.

@SenseException SenseException merged commit 424241f into doctrine:2.7 Aug 9, 2020
@greg0ire greg0ire deleted the fix-misleading-doc branch August 9, 2020 21:12
@greg0ire
Copy link
Member Author

greg0ire commented Aug 9, 2020

Haha yeah I messed up, thanks for pointing that out, I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants