Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/inflector v2.0 #8246

Closed
wants to merge 1 commit into from
Closed

Allow doctrine/inflector v2.0 #8246

wants to merge 1 commit into from

Conversation

svycka
Copy link
Contributor

@svycka svycka commented Aug 24, 2020

doctrine/inflector Release 2.0.0
This release drops the deprecated legacy API. To allow installing this version, please upgrade to the new API, then change the composer constraint for inflector to "doctrine/inflector": "^1.4 || ^2.0.

but I can't because doctrine/orm requires only 1.4 version. Maybe doctrine/orm not ready yet?

not sure how to update composer.json tried like this but :(

vytautas@work ~/p/g/doctrine2> composer update                                                                                                                                                                                                                                                                                                                                                                           patch-2
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - doctrine/inflector 2.0.3 requires php ^7.2 || ^8.0 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 2.0.2 requires php ^7.2 || ^8.0 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 2.0.1 requires php ^7.2 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 2.0.0 requires php ^7.2 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 1.4.x-dev requires php ^7.2 || ^8.0 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 1.4.3 requires php ^7.2 || ^8.0 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 1.4.2 requires php ^7.2 || ^8.0 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 1.4.1 requires php ^7.2 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - doctrine/inflector 1.4.0 requires php ^7.2 -> your PHP version (7.4.9) overridden by "config.platform.php" version (7.1.3) does not satisfy that requirement.
    - Installation request for doctrine/inflector ^1.4 || ^2.0 -> satisfiable by doctrine/inflector[1.4.0, 1.4.1, 1.4.2, 1.4.3, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 1.4.x-dev].

vytautas@work ~/p/g/doctrine2> php -v                                                                                                                                                                                                                                                                                                                                                                                  2 patch-2
PHP 7.4.9 (cli) (built: Aug  7 2020 14:29:36) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.9, Copyright (c), by Zend Technologies

@greg0ire
Copy link
Member

You should start from 2.8.x since this is clearly not a bugfix. It will work better, since 2.8.x does not require compatibility with php 7.1.

@svycka
Copy link
Contributor Author

svycka commented Aug 25, 2020

You should start from 2.8.x since this is clearly not a bugfix. It will work better, since 2.8.x does not require compatibility with php 7.1.

@greg0ire the problem is not php7.1 the problem is that I can't install https://github.com/doctrine/DoctrineModule/blob/4.x/composer.json#L53 and this already fixed in 2.8.x just not released as I understand if we could get 2.8 released then we can close this.

But I don't know why you did not add this in #8158 I thought maybe this is a bug. If not you can close.

@greg0ire
Copy link
Member

greg0ire commented Aug 25, 2020

I negotiated internally to be passed in 2.7 although it's not a bug, because it allows us to drop unwanted things, as described here: #8158 (comment) Thanks, but that is not the case for inflector.

@greg0ire greg0ire closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants