psalm fixes #8286
Merged
psalm fixes #8286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
force-pushed
the
psalm-fixes-2
branch
from
5282237 to
55335ec
Compare
greg0ire
reviewed
Sep 28, 2020
orklah
force-pushed
the
psalm-fixes-2
branch
from
4aa4456 to
f7875d8
Compare
SenseException
approved these changes
Sep 29, 2020
greg0ire
approved these changes
Sep 29, 2020
| @@ -397,6 +397,8 @@ class ClassMetadataInfo implements ClassMetadata | |||
| * Whether a unique constraint should be generated for the column. | |||
| * | |||
| * @var array | |||
| * | |||
| * @psalm-var array<string, array{type: string, fieldName: string, columnName: string, inherited: class-string}> | |||
There was a problem hiding this comment.
/cc @orklah nullable is missing here. Also, all the array keys are supposed to be optional but here they're required...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR propose fixing about 170 issues detected by Psalm at level 6.
If merged, there will be about 30 issues left to permanently raise the level to 6.
There was a lot of miscs modifications so it was difficult to separate in smaller PR. Please leave a review note on any modification you want to know more, I'll explain why the fix was relevant/necessary