Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Embeddable associations in SchemaValidator #8291

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Validate Embeddable associations in SchemaValidator #8291

merged 1 commit into from
Oct 17, 2020

Conversation

mateuszsip
Copy link
Contributor

Resolves #8052

@beberlei
Copy link
Member

@kejwmen can you rebase this onto the 2.8.x branch, this should not go into 2.7 brach. I'll merge then.

@beberlei beberlei added this to the 2.8.0 milestone Oct 11, 2020
@mateuszsip mateuszsip force-pushed the 8052-validate-embeddables branch from 060b45e to 30aa5be Compare October 14, 2020 09:08
@mateuszsip mateuszsip changed the base branch from 2.7 to 2.8.x October 14, 2020 09:08
@mateuszsip
Copy link
Contributor Author

@beberlei sure, done!
Looks like travis build didn't trigger: https://travis-ci.org/github/doctrine/orm/requests

SenseException
SenseException approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close and reopen PR to restart build. If the build doesn't break this is 👍

@mateuszsip mateuszsip closed this Oct 16, 2020
@mateuszsip mateuszsip reopened this Oct 16, 2020
@greg0ire greg0ire closed this Oct 17, 2020
@greg0ire greg0ire reopened this Oct 17, 2020
@greg0ire
Copy link
Member

Let's try again, I recently fixed the 2.8.x build

@greg0ire greg0ire requested a review from beberlei October 17, 2020 11:46
@beberlei beberlei merged commit 53dc5b2 into doctrine:2.8.x Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@beberlei beberlei beberlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Validate Embeddables in SchemaValidator
4 participants
@mateuszsip @beberlei @greg0ire @SenseException