[GH-6855] Prevent unsupported lifecycle callback mapping on embedded classes. #8381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initionsOnEmbeddededClasses
SenseException
previously approved these changes
Mar 1, 2021
beberlei
deleted the
GH-6855-PreventLifecycleCallbackDefinitionsOnEmbeddededClasses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6855
For now we want to throw a deprecation message when a lifecycle callback is put on an
Embeddedclass, because they are not actually recognized, are not called and instead they are just ignored.In 3.0 then this will be changed to throw an exception, so that users will immediately see they are doing something wrong.