Introduce doctrine/deprecations #8466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Feb 7, 2021
greg0ire
reviewed
Feb 7, 2021
greg0ire
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using alpha version of doctrine/deprecations (v0.2.0) replace all usages of
trigger_errorand replace tests usingVerifyDeprecations. During implementation realized a few changes to API needed leading to these PRs that were merged into v0.2:The tests were cleaned up a lot with assertions about deprecations, it is not helpful to have the same deprecation asserted on in hundrets of different, unrelated tests.
Uncoditional deprecations are not tested anymore, because their code is trival and does not affect runtime behavior. Only conditional deprecations are still tested.
This PR also undeprecates
EntityManager::detachfor now, because unless we find some kind of replacement API it cannot be removed as relied on heavily by the batch processing use-cases withAbstractQuery::toIterable.