SchemaValidator: Fix mapped superclass missing in discriminator map #8903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsavmic
changed the title
olsavmic
force-pushed
the
fix-schema-validator-for-mapped-superclass-inheritance
branch
from
6386dec to
db17aaa
Compare
olsavmic
force-pushed
the
fix-schema-validator-for-mapped-superclass-inheritance
branch
from
db17aaa to
5685dc0
Compare
|
Great fix @olsavmic This will help me too. Can someone please review it? |
SenseException
approved these changes
Sep 4, 2021
|
Thanks @olsavmic ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8771
I'm not sure if it's actually valid case for a MappedSuperclass to be a part of the DiscriminatorMap.
It looks like the discussion continues in #8415, #7825.
This is a fix for the current behaviour so that it does not block people from upgrading to ORM 2.9