Remove detach deprecation entry in UPGRADE.md #8978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
approved these changes
Sep 5, 2021
derrabus
approved these changes
Sep 5, 2021
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 8, 2021
* 2.9.x: Restore functional cache tests (doctrine#8981) Fix English in `note`. (doctrine#8987) Remove detach deprecation entry in UPGRADE.md (doctrine#8978) Bump to PHPStan 0.12.98 and Psalm 4.10.0 (doctrine#8979)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 8, 2021
* 2.9.x: Restore functional cache tests (doctrine#8981) Fix English in `note`. (doctrine#8987) Remove detach deprecation entry in UPGRADE.md (doctrine#8978) Bump to PHPStan 0.12.98 and Psalm 4.10.0 (doctrine#8979) Signed-off-by: Alexander M. Turek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detach method is an important tool in some circumstances. Even when following the doctrine-orm development from time to time it was hard to track the reversal of the deprecation.
Removing this still existing entry in the upgrade.md could prevent some more confusion.
I know it might get deprecated again at some point...