Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML export for change-tracking-policy #9285

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

Fedik
Copy link
Contributor

@Fedik Fedik commented Dec 23, 2021

The change-tracking-policy is an attribute, not an Entity child.

Even thought the xml exporter is deprecated it still should produce valid output for 2.x series ;)

@derrabus derrabus added the Bug label Dec 23, 2021
@derrabus derrabus added this to the 2.10.5 milestone Dec 23, 2021
@derrabus
Copy link
Member

Even thought the xml exporter is deprecated it still should produce valid output for 2.x series ;)

The exporter might be depreacted, but since we also deprecated the YAML mapping, the XML exporter will have one last mission before we remove it. 🦸🏻

Thank you for your contribution!

@derrabus derrabus merged commit 5ccf2ea into doctrine:2.10.x Dec 23, 2021
@Fedik Fedik deleted the fix-xml-export-trck-pol branch December 24, 2021 07:56
derrabus added a commit that referenced this pull request Dec 26, 2021
* Better explain limitations of DQL "DELETE" (#9281)

We think the current documentation does not stress these details enough, so that they are easily overlooked.

Co-authored-by: Malte Wunsch <[email protected]>

Co-authored-by: Malte Wunsch <[email protected]>

* Put actual value instead of index inside $originalEntityData. (#9244)

This fixes a bug with redundant UPDATE queries, that are executed when some entity uses foreign index of other entity as a primary key. This happens when after inserting related entities with $em->flush() call, you do the second $em->flush() without changing any data inside entities.
Fixes GH8217.

Co-authored-by: ivan <[email protected]>

* Allow symfony/cache 6 (#9283)

* Fix XML export for `change-tracking-policy` (#9285)

* Whitelist composer plugins used by this repository (#9286)

Co-authored-by: Matthias Pigulla <[email protected]>
Co-authored-by: Malte Wunsch <[email protected]>
Co-authored-by: Ivan Strygin <[email protected]>
Co-authored-by: ivan <[email protected]>
Co-authored-by: Fedir Zinchuk <[email protected]>
derrabus added a commit to derrabus/orm that referenced this pull request Dec 26, 2021
* 2.11.x:
  Enable UnusedUse sniff again (doctrine#9267)
  Whitelist composer plugins used by this repository (doctrine#9286)
  Fix XML export for `change-tracking-policy` (doctrine#9285)
  Allow symfony/cache 6 (doctrine#9283)
  Put actual value instead of index inside $originalEntityData. (doctrine#9244)
  Fix return types of cache interfaces (doctrine#9271)
  Better explain limitations of DQL "DELETE" (doctrine#9281)
  Fix docblocks on nullable EM properties (doctrine#9273)
  Docs: use canonical order for phpdoc tags, add missed semicolon (doctrine#9190)
  Make PrimaryReadReplicaConnection enforcement explicit (doctrine#9239)
  Regenerate Psalm baseline (doctrine#9272)
  Improve compatibility with Doctrine DBAL 4 (doctrine#9266)
  [docs] Fix wording for attributes=>parameters. (doctrine#9265)
  Support for nesting attributes with PHP 8.1 (doctrine#9241)
  Revert "Fix SchemaValidator with abstract child class in discriminator map (doctrine#9096)" (doctrine#9262)
  Docs: consistency for FQCN, spacing, etc (doctrine#9232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants