Fix union type on QueryExpressionVisitorTest::testWalkComparison() #9294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Dec 27, 2021
| * @psalm-return list<array{ | ||
| * 0: CriteriaComparison, | ||
| * 1: QueryBuilder\Comparison|QueryBuilder\Func|string, | ||
| * 2?: Parameter, |
There was a problem hiding this comment.
Is this different than the previous specification for this parameter? Previously it meant always present but possibly null, whereas here it would mean never null, but optional? If there is no difference then are the numbers necessary?
There was a problem hiding this comment.
Exactly. And if you look at the data provider you'll find that the declaration "never null, but optional" is more accurate.
Oh, and the closing > was missing, so the previous type declaration was invalid and thus ignored.
greg0ire
approved these changes
Dec 27, 2021
derrabus
added a commit
that referenced
this pull request
Dec 28, 2021
* Bump reusable workflows * Fix union type on QueryExpressionVisitorTest::testWalkComparison() (#9294) * Synchronize Psalm baseline (#9296) * Fix return type (#9295) Co-authored-by: Grégoire Paris <[email protected]>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 28, 2021
* 2.11.x: Fix return type (doctrine#9295) Synchronize Psalm baseline (doctrine#9296) Fix union type on QueryExpressionVisitorTest::testWalkComparison() (doctrine#9294) Allow arithmetic expressions within IN operator (doctrine#9242) Bump reusable workflows
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 28, 2021
* 2.11.x: Leverage get_debug_type() (doctrine#9297) Fix return type (doctrine#9295) Synchronize Psalm baseline (doctrine#9296) Fix union type on QueryExpressionVisitorTest::testWalkComparison() (doctrine#9294) Allow arithmetic expressions within IN operator (doctrine#9242) Bump reusable workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while working on #9293